search

ansible-lockdown / RHEL8-CIS

Ansible role for Red Hat 8 CIS Baseline
https://ansible-lockdown.readthedocs.io/en/latest/
MIT License
263 stars 162 forks source link

Update Alma 8 GPG Key #369

Closed ajython closed 3 months ago

ajython commented 5 months ago

Update AlmaLinux.yml

Overall Review of Changes: Following Alma 8 GPG change, the new GPG key needs updating.

Issue Fixes: Please list (using linking) any open issues this PR addresses

Enhancements: Please list any enhancements/features that are not open issue tickets

How has this been tested?: N/A

uk-bolly commented 3 months ago

Hi

Thank you for taking the time to raise this PR, really appreciate the fact the url is also added to show the reasoning behind this. However while all looks good the value that is searched for in the command works a little different. We are looking for the keyID reference from the release package. in this case the value would be 2ae81e8aced7258b. This can be seen in the check command that is run in the tasks (it discovers the release rpm)

rpm -q --queryformat "%{PACKAGER} %{SIGPGP:pgpsig}\n" almalinux-release-8.10-1.el8.x86_64

The link that you provided really helped to point us in the correct direction.

If you want to change the value and add to README, happy to accept the PR or i am able to bring this into another PR i'm currently working on.

Many thanks

uk-bolly

p.s. Also thinking a pre-check maybe a good idea to ensure the version of the release package is 8.8-3 as minimum for alma

ajython commented 3 months ago

Hello, I've updated the PR with the new KeyID. Feel free to merge it with your PR if this needs more work. Thanks

uk-bolly commented 3 months ago

Hello, I've updated the PR with the new KeyID. Feel free to merge it with your PR if this needs more work. Thanks

Brilliant work thank you, always nice to be able to merge someone PR rather than add credits.

Thank you

uk-bolly