ansible-lockdown / RHEL9-CIS

Ansible role for Red Hat 9 CIS Baseline
https://ansible-lockdown.readthedocs.io
MIT License
123 stars 93 forks source link

Fix inject_facts_as_vars #115

Closed jovial closed 8 months ago

jovial commented 11 months ago

Also enabled testing of this in CI to prevent regressions.

See:

Overall Review of Changes: A general description of the changes made that are being requested for merge

Issue Fixes: Please list (using linking) any open issues this PR addresses

Enhancements: Please list any enhancements/features that are not open issue tickets

How has this been tested?: Tested locally and have enabled testing of this in CI to prevent regressions.

uk-bolly commented 11 months ago

hi @jovial

Thank you for taking the time to raise this PR, unfortunatley i have noticed that the GPG signature is missing from the commit. If you could possibly add that i am happy to merge.

Many thanks

uk-bolly

uk-bolly commented 10 months ago

hi @jovial

Thank you for taking the time to raise this PR, unfortunately i have noticed that the GPG signature is missing from the commit. If you could possibly add that i am happy to merge.

Many thanks

uk-bolly

Hi @jovial

I am hoping to get round and update these early in the new year. If you can get this GPG signed happy to accept the PR.

Thank you once again

uk-bolly

uk-bolly commented 8 months ago

hi @jovial

We will be pushing a new release shortly. I would like to include this change, if you could please ensure it is signed off and gpg signed correctly so we can incorporate the changes into the upcoming release.

Many thanks

uk-bolly

uk-bolly commented 8 months ago

hi @jovial

I have incorporated this change in to the latest feb24 updates and is now in devel branch. Thank you again for raising this.

kindest regards

uk-bolly