search

ansible-lockdown / RHEL9-CIS

Ansible role for Red Hat 9 CIS Baseline
https://ansible-lockdown.readthedocs.io
MIT License
113 stars 86 forks source link

fixing some mismatched tags and tasks in 5.6.1.x #150

Closed numericillustration closed 6 months ago

numericillustration commented 8 months ago

Overall Review of Changes: task 5.6.1.1 was mistagged as 5.5.11 task 5.6.1.5 was mistagged as 5.5.1.5

Issue Fixes: https://github.com/ansible-lockdown/RHEL9-CIS/issues/149

Enhancements: Please list any enhancements/features that are not open issue tickets

How has this been tested?: Please give an overview of how these changes were tested. If they were not please use N/A

uk-bolly commented 7 months ago

hi @numericillustration

Thank you for the PR, good catch on the entries, i have noticed hoever that the GPG signature is missing from your commit, if you could please add this as it is required, we are then very happy to accept this.

Many thanks

uk-bolly

numericillustration commented 7 months ago

@uk-bolly ok great, I've gone through the GH docs on doing this and have both signed the commit as well as added my key to gh so it verifies now. Happy to contribute.

numericillustration commented 7 months ago

apologies, had to amend and also sign off again

git commit --amend -s -S -m "fixing some mismatched tags and tasks in 5.6.1.x"
git push --force origin devel

happy to collaborate and improve this body of work.

uk-bolly commented 6 months ago

Great work thank you