Closed RoboPickle closed 6 months ago
hi @RoboPickle
This is a great update, thank you for taking the time, could you possibly add the empty line before each named task just for consistency. You will find the vars deprecation should have already nbeen picked up as well in and earlier PR.
Many thanks
uk-bolly
Hi,
You are most welcome. I've added the blank lines which actually makes a real difference with the readability.
I missed that the deprecation was already handled by another PR!
Thanks
John
Overall Review
tasks/main.yml was altered to handle the user not being found in /etc/shadow.
The grep has been changed.
In the event that the user is not found in /etc/shadow then the response "not found:not found" is given. This is then picked up by the following block to skip the password checking. A debug message is used to alert the user that this is happening.
An additional check is now being made for local accounts to check that the account has not been locked. This is achieved by checking for a single "!" at the beginning of the password hash.
Also updated dictionary in 6.1.11 to convert vars to dictionary to avoid deprecation warning.
Issue Fixes:
Fixes #176: Using an AD account to connect to host incorrectly fails rule 5.3.4
Enhancements:
Fixes #168 DEPRECATION WARNING is generating when play task 6.1.11 | AUDIT | Ensure no ungrouped files or directories exist
How has this been tested?:
Tested against a minimally configured Alma Linux 9 VM.
Addendum: 6.1.11 Deprecation warning during audit. Updated vars to dictionary and deprecation warning avoided.
More details on testing are available if required.