Small changes, improved consistency

[ipruteanu-sie]

Overall Review of Changes: Additions done to improve variables/tasks consistency.

Issue Fixes: N/A

Enhancements: Consistency improvement.

How has this been tested?: N/A

[uk-bolly]

hi @ipruteanu-sie

Thank you for raising the PRs again, it appears you havent pulled the latest in and the pipelines are now failing. I have just tested and this is workinmg on the latest devel. So your local copy maybe out of sync.

If you could close off older PRs you consider no longer required and the associated issues, it will enable to direct attention to those that need attention.

Many thanks

uk-bolly

[ipruteanu-sie]

Hi @uk-bolly . I made a mistake indeed, but my colleague @raabf helped me out (many thanks!!) with rebasing it, I'd say it should be in good shape, as it branches off out of your Feb updates:

rhel9-cis> git log -2
commit f3a91007347cfddf26ab18adecd6f88410b9572f (HEAD -> siemens/feat/fix_inconsistencies, origin/siemens/feat/fix_inconsistencies)
Author: Pruteanu <ionut.pruteanu@siemens.com>
Date:   Fri Feb 16 18:59:31 2024 +0200

    Small changes, improved consistency

    Signed-off-by: Pruteanu <ionut.pruteanu@siemens.com>

commit 40bc7aa0829344e9a5bd4df12b98a17607b4d0c6 (origin/devel, fork/devel, devel)
Author: uk-bolly <mark.bollyuk@gmail.com>
Date:   Tue Feb 20 15:43:43 2024 +0000

    Feb24 updates (#179)

    * change logic thanks to @rjacobs1990 see #175

    Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

    * thanks to @ipruteani-sie #134

    Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

The only reference about the undefined-variable causing the pipeline to fail is here, where it is used, but I cannot find where it is defined. Can you help me out with this info, since your devel pipelines work just fine?

In my opinion, current PRs are not older, but:

• they seem to share same issue about the above ansible var: ansible_machine
• if you feel they are not helpful, please feel free to close them

[ipruteanu-sie]

This is part of devel right now.