Closed jovial closed 7 months ago
hi @jovial
Thank you for this PR, Great catch and update, unfortunatley the change is not GPG signed so i am not able to merge this into the devel branch. If you can sign the commits happy to merge the PR.
Many thanks
uk-bolly
hi @jovial
Thank you for this PR, Great catch and update, unfortunatley the change is not GPG signed so i am not able to merge this into the devel branch. If you can sign the commits happy to merge the PR.
Many thanks
uk-bolly
Thanks for taking a look. I think the issue was that I hadn't uploaded my GPG to github. I've now uploaded this and the commits are showing as verified in the UI. Let me know if I need to do anything else.
Overall Review of Changes:
Fixes regression in using inject-facts-as-vars=false.
See:
Issue Fixes: Please list (using linking) any open issues this PR addresses
Enhancements: Please list any enhancements/features that are not open issue tickets
How has this been tested?: Tested locally and have enabled testing of this in CI to prevent regressions.