reboot task is not idempotent

[bhuddah]

Describe the Issue The implementation of the reboot task makes it impossible to converge with this role.

Expected Behavior Reboot is only done when needed and no change is enforced when skip_reboot is set.

Actual Behavior Right now you either get a change with the warning that a reboot is needed (even if it is not so) or you reboot all machines and get that as a reported change

Control(s) Affected "Reboot system"

Environment (please complete the following information):

• branch being used: release 1.3.5
• Ansible Version: 2.16.3
• Host Python Version:Python 3.10.12
• Ansible Server Python Version: 3.10.12
• Additional Details: -

Additional Notes Anything additional goes here

Possible Solution Reboot is handled via handler and only done when needed.

[uk-bolly]

hi @bhuddah

I believe that this issue has been addressed and the fix merged? I will close this issue, please feel free to reopen or raise a new one if this particular problem still exists.

Many thanks

uk-bolly

[bhuddah]

hi @bhuddah

I believe that this issue has been addressed and the fix merged? I will close this issue, please feel free to reopen or raise a new one if this particular problem still exists.

Many thanks

uk-bolly

Yes, issue is resolved. thanks a lot for the quick fix.