search

ansible-lockdown / Windows-2019-CIS

CIS Baseline Ansible Role for Windows 2019
MIT License
130 stars 70 forks source link

Fixed typo in Private firewall policy registry key. #57

Closed trippsc2 closed 2 years ago

trippsc2 commented 2 years ago

Overall Review of Changes: A backslash was omitted in the task for patching item 9.2.1. It has been corrected.

Issue Fixes: N/A

Enhancements: N/A

How has this been tested?: Molecule testing indicates that the role successfully executes this task.

georgenalen commented 2 years ago

@trippsc2, Thanks for the PR, would you be able to update the commit to have a gpg signature and the signed-off by part as well? To merge into devel those are part of the DCO requirements. If it's a huge pain to get that sorted I can add the change myself and mention you in the commit and reference this PR.

-George

trippsc2 commented 2 years ago

@georgenalen

I've rebased my branch and signed the commit. I'm new to GPG signing commits, so if it is still not acceptable, it may be more expedient to replicate the change and provide credit.

georgenalen commented 2 years ago

@trippsc2, Thanks for working on it. When updating for the latest benchmarks I fixed that one (there is actually one other with the same issue) without realizing it was part of this PR. I'm still not seeing the green verified. What I'm going to do is on the PR I raise for the updates into devel I'll reference this one and you on it, and close this one. Thanks again for putting in the work to fix this, as well as the work getting the commits to align to DCO policies.

-George