search

ansible-lockdown / Windows-2019-CIS

CIS Baseline Ansible Role for Windows 2019
MIT License
130 stars 70 forks source link

Check Mode for section 17 2 commits as after commit I found another. #58

Closed kris9854 closed 1 year ago

kris9854 commented 1 year ago

Overall Review of Changes: Fixed the Audit rules within section 17. You are now able to do --check when running ansible without failure.

Issue Fixes: None found issues. Mainly providing this as a thank you for the hard work you people did. Just wanted to give back

Enhancements: Able to do --check when running ansible-playbook. Given the option to do a audit run within ansible. Without using goss.

How has this been tested?: Yes used "ansible-playbook site.yml -i inventory -k --check -t section17" . Though fixing the hole role would mean to go through testing all the tags. Some of the HKEY paths doesn't exist.

uk-bolly commented 1 year ago

hi @kris9854

Thank you for the feedback and PR, This is a very helpful update.

Consider it merged.

Thank you for your time great work.

uk-bolly

kris9854 commented 1 year ago

No problem, your work did a heck of a lot for me to. So will start creating more PR's, bugs and suggestions whenever I got some spare time :).

Just happy that my first ever PR got approved to the project :D