search

ansible-lockdown / Windows-2019-CIS

CIS Baseline Ansible Role for Windows 2019
MIT License
135 stars 73 forks source link

Fix issue #59, General Space problem cleanup, dependencies adding + bug fix #60

Closed kris9854 closed 2 years ago

kris9854 commented 2 years ago

Overall Review of Changes:

Issue Fixes: Added a fix to BUG report #59 Non bug fixes that I didn't create just fixed it and made this PR.

Enhancements: --check can know be done without ANY errors.

How has this been tested?: Tested using ansible-core, "pywinrm>=0.2.2, collections installed community.windows and ansible.windows. Lab setup was Almalinux 9 as ansible host, and windows 2019 VM. Both on hyper-v. Haven't tested without --check as my test setup isn't using anything else than NTLM.

kris9854 commented 2 years ago

@uk-bolly unsure if those collections should have been in a collection keyword instead of in the dependencies section. Like the rhel9-CIS role.