ansible-lockdown / Windows-2019-CIS

CIS Baseline Ansible Role for Windows 2019
MIT License
130 stars 72 forks source link

empty lists to empty string #9

Closed kclinden closed 3 years ago

kclinden commented 3 years ago

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: at System.Management.Automation.CommandProcessor.Read() fatal: [w2019]: FAILED! => {"changed": false, "msg": "Unhandled exception while executing module: Cannot bind argument to parameter 'InputObject' because it is an empty string."}

georgenalen commented 3 years ago

kclinden, Thanks for the work on getting these sorted but I think the user: "" you added should be user: [] instead. I ran it locally with the double quotes and it failed with a similar error to what you were seeing, different but similar. Looking deeper at the module documentation it looks like the brackets are what is needed.

I ran a test with the hand full of controls you added the double quotes to, but updated with brackets, and got the correct behavior. On the test system I brought it out of compliance for those controls, basically adding a user to those policy options. Then when I ran those controls with brackets it cleared those users from those options, which is the expected behavior.

With that I am doing some work on other issues as well. I will add these fixes into those changes and make mention of this PR when I push those changes through to main. I'll leave this one open while I work on the others just incase I'm missing something you can reply here to stop me from making a further mistake. If I don't hear back in a few days I'll assume all is good and close this one.

George

kclinden commented 3 years ago

Nope that works for me. Thanks @georgenalen