search

ansible-lockdown / Windows-2019-CIS

CIS Baseline Ansible Role for Windows 2019
MIT License
134 stars 72 forks source link

Fix CIS control ids #99

Closed mfortin closed 5 months ago

mfortin commented 6 months ago

Overall Review of Changes: CIS control ids mismatch

Issue Fixes: Update ID, removed one and fixed order of others

Enhancements: none

How has this been tested?: Ansible playbook from a local workstation to an EC2 instance in AWS

frederickw082922 commented 6 months ago

Thank you for the PR @mfortin ! The playbook failed during the Pipeline run!

TASK [/github/workspace : 18.9.32.6.2 | PATCH | Ensure Allow network connectivity during connected-standby plugged in is set to Disabled] *** fatal: [AL]: FAILED! => {"msg": "The conditional check 'win19cis_rule_18_3_32_6_2' failed. The error was: error while evaluating conditional (win19cis_rule_18_3_32_6_2): 'win19cis_rule_18_3_32_6_2' is undefined. 'win19cis_rule_18_3_32_6_2' is undefined\n\nThe error appears to be in '/github/workspace/tasks/section18.yml': line 1757, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: \"18.9.32.6.2 | PATCH | Ensure Allow network connectivity during connected-standby plugged in is set to Disabled\"\n ^ here\n"}

mfortin commented 6 months ago

@frederickw082922 I fixed the rule condition, there was a typo there too.

mfortin commented 6 months ago

There are still 2 updates that did not get ported in #100. One is minor, the other one prevents this role from executing on Amazon EC2 instances due to a race condition related to the ordering of controls in section 01.