search

ansible-lockdown / Windows-2022-CIS

CIS Baseline Ansible Role for Windows 2022
MIT License
72 stars 31 forks source link

Only applies to Azure #34

Closed mfortin closed 8 months ago

mfortin commented 8 months ago

Overall Review of Changes: Alternate ordering of section 01 controls only applies to Azure, this cloud detection only checks for Azure Virtual Machines right now.

Issue Fixes:

33

Enhancements: None

How has this been tested?: I tested from the repo/branch from this PR

Results:

TASK [Windows-2022-CIS : 1.2.2 | PATCH | Ensure Account lockout threshold is set to 5 or fewer invalid logon attempt(s), but not 0. | Set Variable.] ***
changed: [10.0.0.3]

TASK [Windows-2022-CIS : 1.2.3 | PATCH | Ensure Allow Administrator account lockout is set to Enabled] ***
changed: [10.0.0.3]

TASK [Windows-2022-CIS : 1.2.4 | PATCH | Ensure Reset account lockout counter after is set to 15 or more minutes. | Set Variable.] ***
changed: [10.0.0.3]

TASK [Windows-2022-CIS : 1.2.1 | PATCH | Ensure Account lockout duration is set to 15 or more minutes. | Set Variable] ***
changed: [10.0.0.3]
georgenalen commented 8 months ago

Hey @mfortin, Thanks for the PR. It looks good but for one thing. We require commits to have the signed off by along with the GPG signature (which you have). If you would be able to add the signed-off-by flag that would allow us to merge this one in. If need more details on that it's the -s option when committing. If you have additional questions let me know.

frederickw082922 commented 8 months ago

Thank you @mfortin !