ansible-lockdown / Windows-2022-CIS

CIS Baseline Ansible Role for Windows 2022

MIT License

73 stars 31 forks source link

Addressing issue 38 #39

Closed mfortin closed 7 months ago

mfortin commented 8 months ago

Overall Review of Changes: Updating controls as per expected results from CIS Benchmark

Issue Fixes:

38

Enhancements: None

How has this been tested?: Tested by running role from this branch on a fresh instance

MrSteve81 commented 8 months ago

Please Fix your Sign off for the DCO. I have gone over this PR and It looks great thanks for the finds.

mfortin commented 8 months ago

@MrSteve81 fixed the DCO!

frederickw082922 commented 8 months ago

Thank you @mfortin ! Great Catches!

CC: @georgenalen @MrSteve81

frederickw082922 commented 7 months ago

Good day @mfortin ! FYI, your commits are still populating not "Verified". Think options are Re-do your commits with "sign-off-by and verified"? Or I can do a new branch with your updates based on your PR #39?

mfortin commented 7 months ago

Looks like I messed that up!