ansible-middleware / amq_streams

Apache License 2.0
9 stars 7 forks source link

Enable Broker Authentication usign SASL mechanism #35

Closed rmarting closed 1 year ago

rmarting commented 1 year ago

This PR implements the #34 issue, but only focused in the SASL authentication mechanisms (nothing about TLS or secured connections).

This implementation is based on this documentation. Including the feature of enable different listeners and identify which one use for the inter-broker connections.

Using an inter-broker listener is a good pattern to split the traffic between consumers/producers and the internal broker. This feature covers the case of an authenticated listener too.

PS: This PR was implemented as an extension of the PR #33 (this is way some of the commits are described here).

rmarting commented 1 year ago

@guidograzioli @rpelisse What do you think?

rmarting commented 1 year ago

Added an extension to manage the authentication in the Kafka Connect cluster. Otherwise the Kafka connect will not be able to connect to an authenticated Kafka cluster managed by this collection.

rmarting commented 1 year ago

@rpelisse Merge done from the main branch. PR ready for your review!

rpelisse commented 1 year ago

Superseeded by https://github.com/ansible-middleware/amq_streams/pull/43

rmarting commented 1 year ago

Glad to see that my contributions are now merged into the main branch after the amazing review of my colleague @rpelisse. A great step forward of this collection.

Neustradamus commented 1 year ago

@rmarting, @rpelisse: Good job!

Linked to: