search

ansible-middleware / amq_streams

Apache License 2.0
9 stars 7 forks source link

Issue31 extension #50

Closed rmarting closed 1 year ago

rmarting commented 1 year ago

PR to extend the review of the #31.

This PR only adds some extra commits declaring the default values of java heap opts for each component (zk, bk, connect), and the documentation.

rmarting commented 1 year ago

@rpelisse can you check the commits were merged successfully? I think you merged after you merged the ISSUE31 branch. I can't see the commits into the main branch.

rpelisse commented 1 year ago

Indeed! I've pushed the commit back into main manually. It is weird though, I need to be more careful next time, but normally "rebase and merge" should add your commits to the top of the branch :thinking: .