Close #182, #221: improve restart handler logic

ansible-middleware / keycloak

Collection to install and configure Keycloak or Red Hat Single Sign-On / Red Hat Build of Keycloak

Apache License 2.0

82 stars 49 forks source link

Close #182, #221: improve restart handler logic #230

Closed hwo-wd closed 2 weeks ago

hwo-wd commented 2 weeks ago

This does restart sequentially (at least a single node gets restarted, then the others);

@guidograzioli:

[ ] not sure whether you want to check the health differently (wait_for_healthy as you stated in #182), but I guess this is the right PR to tackle all these.
[x] Re: #221:

[..] but it would be great to have this part parametrized as well as this part: /realms/master/.well-known/openid-configuration

This does not seem fruitful since the master realm needs to exist always afaik, so this is the perfect place to check against, wdyt?
[x] Re: CI: Not sure why the molecule tests fail, any pointers? Surely it's related to the health_url, but I don't see how...

guidograzioli commented 2 weeks ago

Change is going is right direction, but I have some additional idea on how to handle the restart (ie. include at least a couple of strategies, and allow for plugging in own restart behaviour). Happy to co-author this PR?

guidograzioli commented 2 weeks ago

This does not seem fruitful since the master realm needs to exist always afaik, so this is the perfect place to check against, wdyt?

I totally agree, however parameterizing that urlpath does not harm us either (keeping the current as default of course)

hwo-wd commented 2 weeks ago

Change is going is right direction, but I have some additional idea on how to handle the restart (ie. include at least a couple of strategies, and allow for plugging in own restart behaviour). Happy to co-author this PR?

This does not seem fruitful since the master realm needs to exist always afaik, so this is the perfect place to check against, wdyt?

I totally agree, however parameterizing that urlpath does not harm us either (keeping the current as default of course)

Ok, I've added an keycloak_quarkus_health_check_url_path option