Fix relative path failure in command_parser

ansible-network / network-engine

This role provides the foundation for building network roles by providing modules and plugins that are common to all Ansible Network roles.

GNU General Public License v3.0

112 stars 53 forks source link

Fix relative path failure in command_parser #222

Closed trishnaguha closed 5 years ago

trishnaguha commented 5 years ago

Signed-off-by: Trishna Guha trishnaguha17@gmail.com Fixes https://github.com/ansible-network/network-engine/issues/152

The PR fixes the following issue: When playbook is in subdir and it is executed from parent dir, command_parser is unable to detect parser template path if the parser template is not present in the playbook dir and relative path for the template is given to src param.

For example: tguha@tguha ~/localtest $ tree

.
├── ansible.cfg
├── inventory
├── parser_templates
│   └── ios
│       └── show_interfaces.yaml
└── playbooks
    ├── parse.yaml

Playbook:

  - name: parse interfaces using command_parser engine
    command_parser:
      file: "../parser_templates/ios/show_interfaces.yaml"
      ...

Command used: ansible-playbook playbooks/parse.yaml

softwarefactory-project-zuul[bot] commented 5 years ago

Build failed.

tox-linters : RETRY_LIMIT in 14s
ansible-network-tox-py27 : RETRY_LIMIT in 49s
ansible-network-tox-py36 : RETRY_LIMIT in 47s
ansible-network-tox-py37 : RETRY_LIMIT in 45s
dco-license : RETRY_LIMIT in 8s

trishnaguha commented 5 years ago

recheck

trishnaguha commented 5 years ago

cc @cidrblock

softwarefactory-project-zuul[bot] commented 5 years ago

Build failed.

tox-linters : RETRY_LIMIT in 15s
ansible-network-tox-py27 : RETRY_LIMIT in 45s
ansible-network-tox-py36 : RETRY_LIMIT in 45s
ansible-network-tox-py37 : RETRY_LIMIT in 47s
dco-license : RETRY_LIMIT in 9s

trishnaguha commented 5 years ago

recheck

softwarefactory-project-zuul[bot] commented 5 years ago

Build failed.

tox-linters : RETRY_LIMIT in 13s
ansible-network-tox-py27 : RETRY_LIMIT in 47s
ansible-network-tox-py36 : RETRY_LIMIT in 45s
ansible-network-tox-py37 : RETRY_LIMIT in 49s
dco-license : RETRY_LIMIT in 8s

trishnaguha commented 5 years ago

The tests are passing locally

PLAY RECAP ***************************************************************************************************************************************
localhost                  : ok=57   changed=0    unreachable=0    failed=0    skipped=0

softwarefactory-project-zuul[bot] commented 5 years ago

Build failed.

tox-linters : RETRY_LIMIT in 13s
ansible-network-tox-py27 : RETRY_LIMIT in 44s
ansible-network-tox-py36 : RETRY_LIMIT in 47s
ansible-network-tox-py37 : RETRY_LIMIT in 46s
dco-license : RETRY_LIMIT in 9s

pabelanger commented 5 years ago

recheck

pabelanger commented 5 years ago

recheck

softwarefactory-project-zuul[bot] commented 5 years ago

Build failed.

tox-linters : FAILURE in 5m 43s
ansible-network-tox-py27 : SUCCESS in 4m 19s
ansible-network-tox-py36 : SUCCESS in 6m 08s
ansible-network-tox-py37 : SUCCESS in 5m 52s
dco-license : SUCCESS in 38s

softwarefactory-project-zuul[bot] commented 5 years ago

Build succeeded.

tox-linters : SUCCESS in 4m 52s
ansible-network-tox-py27 : SUCCESS in 3m 55s
ansible-network-tox-py36 : SUCCESS in 6m 03s
ansible-network-tox-py37 : SUCCESS in 7m 33s
dco-license : SUCCESS in 39s

softwarefactory-project-zuul[bot] commented 5 years ago

Build succeeded (gate pipeline).

tox-linters : SUCCESS in 5m 01s
ansible-network-tox-py27 : SUCCESS in 4m 12s
ansible-network-tox-py36 : SUCCESS in 5m 35s
ansible-network-tox-py37 : SUCCESS in 6m 18s
dco-license : SUCCESS in 37s

trishnaguha commented 5 years ago

Backported to 2.6.10 #223 .