search

ansible / ansible-builder

An Ansible execution environment builder
Other
287 stars 93 forks source link

No sanitize pip #647

Closed sivel closed 5 months ago

sivel commented 6 months ago

An alternative to #645

This PR just makes no attempt at deduping anything, and removes the sanitization function completely

A few notes about this PR:

  1. The --sanitize option still exists, but is hidden, and it does nothing.
  2. As a result of making --sanitize a noop, the "default" screen format has changed, to more closely match what --sanitize displayed
  3. EXCLUDE_REQUIREMENTS only applied to pip before, simply because sanitize_requirements was only ever used for pip, but it now applies to system as well. We could make EXCLUDE_REQUIREMENTS keyed, and separate them, or put it behind an explicit toggle to the function call
  4. This may push errors down deeper, as we don't care what the line is, so it would just be passed on to pip
sivel commented 5 months ago

Closing in favor of https://github.com/ansible/ansible-builder/pull/663