Jag/reuse build artifacts

ansible / ansible-container

DEPRECATED -- Ansible Container was a tool to build Docker images and orchestrate containers using only Ansible playbooks.

GNU Lesser General Public License v3.0

2.19k stars 392 forks source link

Jag/reuse build artifacts #794

Closed j00bar closed 7 years ago

j00bar commented 7 years ago

ISSUE TYPE

Feature Pull Request

SUMMARY

In rebuilds, when the cache gets "busted", we apply a role cleanly from the previous image. To speed up rebuilds, it makes sense to reapply the role to the same previous intermediate container, in order to take advantage of the performance gains from Ansible's idempotence. This pull request implements such functionality.

Also, this pull request cleans up a ton of test cruft.

j00bar commented 7 years ago

Discussion: do we implement a command-line flag to specifically disable this feature? Or do we say you use this full cache strategy or no cache strategy at all?

chouseknecht commented 7 years ago

@j00bar

I say we merge it, and let user feedback determine which command line flags are needed, if any.