replace characters that are unsafe in docker layer names with a "_"

ansible / ansible-container

DEPRECATED -- Ansible Container was a tool to build Docker images and orchestrate containers using only Ansible playbooks.

GNU Lesser General Public License v3.0

2.19k stars 392 forks source link

replace characters that are unsafe in docker layer names with a "_" #909

Closed jimrobinson closed 6 years ago

jimrobinson commented 6 years ago

ISSUE TYPE

Bugfix Pull Request

SUMMARY

If ansible-container has a path to a role directory that is nested (e.g., roles/some/path/to/role/) it ends up trying to use a layer name that is invalid in Docker.

Docker layer names may not contain characters outside the range [a-zA-Z0-9_.-].

This patch replaces all characters outside the allowed range with underscores.

Voronenko commented 6 years ago

@jimrobinson your fix is in develop now.

Voronenko commented 6 years ago

@jimrobinson fix is in develop as a part of cumulative PR last week, thanks for your input!