search

ansible / ansible-container

DEPRECATED -- Ansible Container was a tool to build Docker images and orchestrate containers using only Ansible playbooks.
GNU Lesser General Public License v3.0
2.19k stars 394 forks source link

Cumulative tests fix - lets get project great again (at least to green tests state) #939

Closed Voronenko closed 6 years ago

Voronenko commented 6 years ago

Colleagues, lets leave develop branch in stable state with green tests at least. It is too nice project to leave it in current "middle" state.

cc: @j00bar , @gregdek , @chouseknecht

ISSUE TYPE
SUMMARY
  1. Fixed travis tests to green state - we have a deadly red line for a while
  2. safe characters filtering for role name in edge cases
  3. Amazon:2 tests - added tar which is now absent in base image
  4. Workaround for non-english file names if any
  5. Pinned docker version to prevent breakage for 3.x.x changes
  6. Support for PIP 10

Changes are UP and green:

https://travis-ci.com/softasap/ansible-container/builds/75429794

gregdek commented 6 years ago

OK, my cursory review plus passing tests tells me that this is good, so I'm gonna go ahead and merge this. Thanks @Voronenko for this work, much appreciated.