search

ansible / ansible-container

DEPRECATED -- Ansible Container was a tool to build Docker images and orchestrate containers using only Ansible playbooks.
GNU Lesser General Public License v3.0
2.19k stars 392 forks source link

Updates setup.py to work with pip9 and pip10 #941

Closed brianbruggeman closed 6 years ago

brianbruggeman commented 6 years ago

Fixes #940

pip10 intentionally broke compatibility to prevent using internals. However, there is no particular package that actually provides a way to read requirements and convert them into a setup.py file, so package developers are stuck with using pip.*.req.

Voronenko commented 6 years ago

Also addressed in:

https://github.com/ansible/ansible-container/pull/920

https://github.com/ansible/ansible-container/pull/923/

https://github.com/ansible/ansible-container/pull/931/

https://github.com/ansible/ansible-container/pull/939

Let's support one single pull request instead?

brianbruggeman commented 6 years ago

Let's support one single pull request instead?

I'm cool with that. I did a search on Pip 10 and I was surprised that didn't see anything in the results.

It's such a stupid easy fix, though, that it would take 10 minutes to review and add... why hasn't it been added in the past month? Additionally, it makes me wonder if the project is dead/dying without that level of support... because this type of failure is just an automatic no-go.

gregdek commented 6 years ago

Thanks @brianbruggeman -- we merged @Voronenko PR #939 for this one.