search

ansible / ansible-content-parser

Apache License 2.0
3 stars 4 forks source link

Removed fixed version specification for black and upgrade ansible-lint to 24.2.3 #39

Closed TamiTakamiya closed 4 months ago

TamiTakamiya commented 5 months ago

Issue: AAP-23227

Description

Update ansible-lint embedded in ansible-content-parser to its latest version (24.2.2).

ansible-lint 24.2.2 specifies black version >=24.3.0, which did not satisfy the condition black==23.7.0 found in ansible-content-parser's requirements files. I needed to remove them to let upgrade ansible-lint.

Testing

Steps to test

  1. Build and install the updated ansible-content-parser from the PR (ref: https://github.com/ansible/ansible-content-parser/wiki/Build)
  2. Execute 
    ansible-content-parser https://github.com/ansible-collections/amazon.aws.git /tmp/out
  3. Make sure /tmp/out directory contains ftdata.jsonl file.

    Scenarios tested

See the Steps to test section above.

justjais commented 5 months ago

+1 to @robinbobbitt comment, we should wait for Lint new release, if this fix is not an urgent requirement. Along with ansible-lint/pull/4113, there's another fix ansible-lint/pull/4115 in the release queue. Also, currently the discussion is ongoing for the fix of the issue.

TamiTakamiya commented 5 months ago

@robinbobbitt @justjais ansible-lint PRs (4113 & 4115) were merged and the new version (24.2.3) was released last week. I have updated this PR with a few more changes found in testing. Would you take a look? Thanks.