search

ansible / ansible-modules-core

Ansible modules - these modules ship with ansible
1.3k stars 1.95k forks source link

device path is optional for cbs #5838

Closed immanetize closed 7 years ago

immanetize commented 7 years ago
ISSUE TYPE
COMPONENT NAME

rax_cbs_attachments

ANSIBLE VERSION
ansible 2.2.0.0
SUMMARY
The rax_cbs_attachments had a required declaration for the device path parameter, ie /dev/xvdn.  Rather than expend the effort to idempotently determine an available device node path at runtime, I consulted upstream documentation and found that the device parameter could be determined at the infrastructure level.  Changed true to false, tested once, seems sane.

per https://developer.rackspace.com/docs/cloud-servers/v2/api-reference/svr-basic-operations/#post-attach-volume-to-server-servers-server-id-os-volume-attachments , device is "The name of the device, such as /dev/xvdb. Specify null for auto- assignment."

gregdek commented 7 years ago

Thanks @immanetize. To the current maintainers, @claco, @sivel please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

ansibot commented 7 years ago

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide.