search

ansible / ansible-modules-core

Ansible modules - these modules ship with ansible
1.3k stars 1.95k forks source link

Remove nat_destination check from openstack FIP #5845

Closed emonty closed 7 years ago

emonty commented 7 years ago

There is no internal_network attribute on a floating ip and adding one would be very expensive. Also, nat_destination is a way to find the right address on a server, it's super helpful in and of itself as an attribute to use for up-to-date checks.

Finally, the equality checking on the internal network is backwards.

Shrews commented 7 years ago

@yfried-redhat Please verify and comment since this pertains to issues you brought up.