oVirt module uses ovirtsdk.xml.params.VM when class is now ovirtsdk.xml.params.Vm

evanfoster commented 8 years ago

ISSUE TYPE

Bug Report

COMPONENT NAME

ovirt module

ANSIBLE VERSION

2.0.0.2

SUMMARY

Hey folks, still new at all of this, I know I should submit a pull request but I don't know how to do so at the moment and I'm pressed for time. Apologies!

The oVirt module repeatedly does this:

vmparams = params.VM(name=...

but the VM class has been renamed to Vm. Looking at the help for Vm, it looks like all parameters match:

class Vm(VmBase)
 |  Method resolution order:
 |      Vm
 |      VmBase
 |      BaseResource
 |      ActionableResource
 |      GeneratedsSuper
 |      __builtin__.object
 |  
 |  Methods defined here:
 |  
 |  __init__(self, actions=None, href=None, id=None, name=None, description=None, comment=None, creation_st
atus=None, link=None, type_=None, status=None, memory=None, cpu=None, cpu_shares=None, bios=None, os=None, 
cluster=None, storage_domain=None, creation_time=None, origin=None, stateless=None, delete_protected=None, 
high_availability=None, display=None, sso=None, rng_device=None, console=None, domain=None, usb=None, sound
card_enabled=None, tunnel_migration=None, migration_downtime=None, virtio_scsi=None, serial_number=None, st
art_paused=None, cpu_profile=None, migration=None, io=None, custom_properties=None, custom_emulated_machine
=None, custom_cpu_model=None, time_zone=None, small_icon=None, large_icon=None, initialization=None, memory
_policy=None, stop_reason=None, host=None, template=None, instance_type=None, start_time=None, stop_time=No
ne, run_once=None, payloads=None, statistics=None, disks=None, nics=None, tags=None, snapshots=None, placem
ent_policy=None, fqdn=None, quota=None, vm_pool=None, cdroms=None, floppies=None, reported_devices=None, wa
tchdogs=None, use_latest_template_version=None, next_run_configuration_exists=None, numa_tune_mode=None, pe
rmissions=None, external_host_provider=None, katello_errata=None, guest_time_zone=None, guest_operating_sys
tem=None, extensiontype_=None)

Should be a pretty simple change, and I apologize that I can't fix it myself and submit a PR.

Thanks much!

Editing to add more information:

oVirt version: 3.6.1 Ansible version: 2.0.0.2 oVirt Engine SDK version: 4.0.0.0-2 OS: Arch Linux

As a quick test, I just changed VM to Vm in ovirt.py and ran it. It looks like things have changed more than I initially thought. I now get this error:

fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "__init__() got an unexpected keyword argument 'clone'"}

Here's roughly what I'm doing:

  disk_alloc: thin
  disk_int: virtio
  image: centos-7-clout-init
  instance_network: ovirtmgmt
  instance_os: rhel_7x64
  instance_type: server
  region: Default
  resource_type: template
  sdomain: Storage
  url: https://xxx.xxx.xxx.xxx
  user: admin@internal
  zone: Default