search

ansible / ansible-modules-extras

Ansible extra modules - these modules ship with ansible
948 stars 1.46k forks source link

Remove ESXi hostname requirement from vmware_guest module #3476

Closed garrettkyle closed 8 years ago

garrettkyle commented 8 years ago
ISSUE TYPE
COMPONENT NAME

vmware_guest

ANSIBLE VERSION
ansible 2.3.0.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = Default w/o overrides
CONFIGURATION
OS / ENVIRONMENT
SUMMARY

When using VMWare vCenter either via the GUI or powershell, vCenter itself is the mechanism by which your destination ESXi host is chosen yet this vmware_guest ansible module is requiring you to manually specify the destination ESXi host which completely defeats the purpose of vCenter and DRS balancing and forces you to do some nasty hacks to work around it.

STEPS TO REPRODUCE
ansibot commented 8 years ago

@jctanner ping, this issue is waiting for your response. click here for bot help

dav1x commented 8 years ago

DRS, HA and cluster technologies are defined at the cluster level. @jctanner added cluster support in a previous PR. This should close this issue. I believe he is updating the docs to reflect that.

@stomplee let me know if I can help further

jctanner commented 8 years ago

resolved_by_pr https://github.com/ansible/ansible-modules-extras/pull/3479

garrettkyle commented 8 years ago

Ok sorry I'm new to this whole Ansible thing. A coworker is better versed in this and directed me to look at the actual code which shows that ESXI_hostname is not required when a cluster is specified. That said, could it not by default specify the default VMWare cluster name that is used if you don't specify otherwise when the cluster is created?

I'm also wondering about the apparent lack of documentation when it comes to the "disks" parameter you pass into vmware_guest. It says it gets read as a list, but I can't see any documentation outside of the example itself as to what options are available? Apologies if I'm just a nub who didn't read enough of the FM :)

Is there any reason why the datastore cannot be specified as a parameter passed to the vmware_guest module?

Basically wouldn't we want to have it work similarly to this?

https://www.vmware.com/support/developer/PowerCLI/PowerCLI41U1/html/New-VM.html

Appreciate the response and thanks for the help!!!