Fetch vmid from the ProxmoxAPI when not set

ansible / ansible-modules-extras

Ansible extra modules - these modules ship with ansible

948 stars 1.46k forks source link

Fetch vmid from the ProxmoxAPI when not set #3591

Closed 0livd closed 7 years ago

0livd commented 7 years ago

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

cloud/misc/proxmox.py

ANSIBLE VERSION

ansible 2.2.0.0

SUMMARY

Fetch vmid from the ProxmoxAPI when it is not set

The vmid is no longer a required parameter For the 'present' state: If not set, the next available one will be fetched from the API For the 'started', 'stopped', 'restarted' and 'absent' states: If not set, the module will try to fetch it from the API based on the hostname Inspired from the behavior of the proxmox_kvm module

gregdek commented 7 years ago

Thanks @0livd. To the current maintainers, @UnderGreen please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

UnderGreen commented 7 years ago

shipit

gregdek commented 7 years ago

Thanks again to @0livd for this PR, and thanks @UnderGreen for reviewing. Marking for inclusion.

[This message brought to you by your friendly Ansibull-bot.]