search

ansible / ansible-modules-extras

Ansible extra modules - these modules ship with ansible
947 stars 1.47k forks source link

Katello module support for repository_sets without a releasever #3639

Closed cliles closed 7 years ago

cliles commented 7 years ago
ISSUE TYPE
COMPONENT NAME

katello

ANSIBLE VERSION
ansible 2.3.0
SUMMARY

The existing logic will fail to add a katello/satellite repository set if that repository set does not have a release version. Some repository sets, like the satellite tools set, do not have a release version. By adding some conditionals we can also support these types of repository sets.

"WARNING:nailgun.client:Received HTTP 422 response: {\"displayMessage\":\"[\\\"releasever\\\"] cannot be specified for Red Hat Satellite Tools 6.2 (for RHEL 6 Server) (RPMs) as that information is not substituable
cliles commented 7 years ago

@ehelms, please review and let me know if I'm doing it wrong.

gregdek commented 7 years ago

Thanks @cliles. To the current maintainers, @ehelms please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

ehelms commented 7 years ago

Thanks @cliles ! This is ready for merge.

ansibot commented 7 years ago

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

cliles commented 7 years ago

@ehelms - seems we didn't ship it in time, and now the repo is locked, I will be moving it over to the main ansible repo :/