ansible / ansible-modules-extras

Ansible extra modules - these modules ship with ansible
948 stars 1.46k forks source link

Conditional main - monitoring #3648

Closed Fale closed 7 years ago

Fale commented 7 years ago
ISSUE TYPE
COMPONENT NAME

monitoring/*

ANSIBLE VERSION
2.2
SUMMARY

Use conditional main as for the 16th point of the module checklist at http://docs.ansible.com/ansible/dev_guide/developing_modules.html#module-checklist that reads:

Call your main() from a conditional so that it would be possible to import them into unittests in the future example:

if __name__ == '__main__':
    main()

@gundalow

gregdek commented 7 years ago

Thanks @Fale. To the current maintainers, @andsens, @brian-brazil, @dstoflet, @eikef, @tbielawa, @bpennypacker, @mcodd, @suprememoocow, @thaumos, @ivanvanderbyl please review according to guidelines (http://docs.ansible.com/ansible/developing_modules.html#module-checklist) and comment with text 'shipit', 'needs_revision' or 'close_me' as appropriate.

[This message brought to you by your friendly Ansibull-bot.]

mcodd commented 7 years ago

shipit

andsens commented 7 years ago

shipit

bpennypacker commented 7 years ago

shipit