search

ansible / ansible-rulebook

Apache License 2.0
196 stars 76 forks source link

chore: pin minor version of aiohttp #723

Closed Alex-Izquierdo closed 1 week ago

Alex-Izquierdo commented 1 week ago

Yesterday, 3.11 version of aiohttp was released with breaking changes which breaks aioresponses library used for our mocks and as consequence some of our tests are failing. Ref: https://github.com/pnuckowski/aioresponses/pull/262

Regardless of whether this is fixed in aioresponses, aiohttp can introduce breaking changes in minor versions, so I pin it to the latest tested version as this library is critical for the stability in some of our features.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bdraco commented 1 week ago

We are going to ship a 3.11.1 to restore back-compat for https://github.com/pnuckowski/aioresponses/pull/262

I want to note that aioresponses could break at any patch release of aiohttp since third party libs that monkey patch aiohttp internals are not something we generally plan for upstream.

If you can use aiohttp's pytest plugin you should be a lot safer off from breaking changes in test infrastructure.

Alex-Izquierdo commented 1 week ago

We are going to ship a 3.11.1 to restore back-compat for pnuckowski/aioresponses#262

I want to note that aioresponses could break at any patch release of aiohttp since third party libs that monkey patch aiohttp internals are not something we generally plan for upstream.

If you can use aiohttp's pytest plugin you should be a lot safer off from breaking changes in test infrastructure.

Thanks for your feedback @bdraco We will explore the plugin that you suggest.