ansible / ansible-runner

A tool and python library that helps when interfacing with Ansible directly or as part of another system whether that be through a container image interface, as a standalone tool, or as a Python module that can be imported. The goal is to provide a stable and consistent interface abstraction to Ansible.
Other
969 stars 357 forks source link

Ensure that UTC ISO8601 datetimes include timezone info #1238

Closed sivel closed 1 year ago

sivel commented 1 year ago

This PR modifies UTC datetime generation to always include a datetime.timezone.utc tzinfo, which ensures that datetimes emitted by runner are correctly indicated to be UTC.

ISO8601 states that missing timezone info indicates localtime, and not UTC.

This should not impact AWX, as the code already defensively corrects this issue:

https://github.com/ansible/awx/blob/2ce9440bab6f14c0eb2f1b85206f1f92dc88fe0d/awx/main/models/events.py#L416-L427

sivel commented 1 year ago

cc @shanemcd @AlanCoding