search

ansible / ansible-runner

A tool and python library that helps when interfacing with Ansible directly or as part of another system whether that be through a container image interface, as a standalone tool, or as a Python module that can be imported. The goal is to provide a stable and consistent interface abstraction to Ansible.
Other
969 stars 357 forks source link

called_once_with should be assert_called_once_with #1284

Closed radez closed 1 year ago

radez commented 1 year ago

This is just a mistake?

Shrews commented 1 year ago

Thanks for spotting this.

radez commented 1 year ago

@Shrews I'm not sure I'm familiar with the tests enough to understand the failure at first glance, would you mind taking a peek at the failure and see if you recognize what's failed?

Shrews commented 1 year ago

@Shrews I'm not sure I'm familiar with the tests enough to understand the failure at first glance, would you mind taking a peek at the failure and see if you recognize what's failed?

Just need to remove the assert up front.

Shrews commented 1 year ago

FYI, codecov data is failing to upload, causing these test failures. I'll re-run them in a bit.

radez commented 1 year ago

Sounds good, thanks