ansible / ansible-zuul-jobs

Zuul job definitions for the Ansible tenant.
Apache License 2.0
23 stars 44 forks source link

Wrong collections path in galaxy-importer job #934

Open jillr opened 3 years ago

jillr commented 3 years ago

After https://github.com/ansible-network/releases/pull/17 stopped bringing in the entire Ansible package it became apparent that the incorrect collections path is being used in this job. Collections which use doc fragments from other collections have been failing CI for all jobs since (ie; community.aws used amazon.aws fragments, and community.okd uses fragments from kubernetes.core).

https://bfcb0036379da16f975f-4282179313616d046bba66d871c7a9ef.ssl.cf5.rackcdn.com/579/16b009a77e4f66d679b0308972f29c92577bf4d3/check/ansible-galaxy-importer/bf50899/job-output.html#l779

In irc we determined this has to do with the collections path https://gist.github.com/jillr/f2a01a25cc902a1a89194a2dccecf749

goneri commented 3 years ago

It's a bug in galaxy-importer. I just opened the issue: https://issues.redhat.com/browse/AAH-650

IMO, the best way to address the problem for now is to embed the fragments in all the collections.

goneri commented 3 years ago

Another option is to ignore the error like Galaxy does. We already run the sanity tests and they check the documentation consistency.