Fact caching fails for hosts that contain / character with file based cache plugins

ryanpetrello commented 6 years ago

SUMMARY

Hosts that contain the / character in their name will cause fact gathering to fail when using file-based plugins, such as jsonfile.

ISSUE TYPE

Bug Report

COMPONENT NAME

gather_facts

ANSIBLE VERSION

ansible 2.5.4
  config file = None
  configured module search path = [u'/home/ryanpetrello/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /home/ryanpetrello/venvs/tmp-f30da7ecd0904ce6/lib/python2.7/site-packages/ansible
  executable location = /home/ryanpetrello/venvs/tmp-f30da7ecd0904ce6/bin/ansible
  python version = 2.7.14 (default, Mar 14 2018, 16:45:33) [GCC 8.0.1 20180222 (Red Hat 8.0.1-0.16)]

CONFIGURATION

$ ansible-config dump --only-changed
(empty)

OS / ENVIRONMENT

Fedora 28

STEPS TO REPRODUCE

$ cat gather.yml
- hosts: all
  gather_facts: true

$ cat inv
[all]
foo/bar ansible_ssh_host=localhost ansible_connection=local

EXPECTED RESULTS

Facts for the foo/bar host to be cached on the local file system.

ACTUAL RESULTS

$ mkdir `pwd`/facts
$ ANSIBLE_CACHE_PLUGIN=jsonfile ANSIBLE_CACHE_PLUGIN_CONNECTION=`pwd`/facts ansible-playbook -i inv gather.yml

PLAY [all] ******************************************************************************************************************************************************

TASK [Gathering Facts] ******************************************************************************************************************************************
 [WARNING]: error in 'jsonfile' cache plugin while trying to write to /home/ryanpetrello/venvs/tmp-f30da7ecd0904ce6/facts/foo/bar : [Errno 2] No such file or
directory: u'/home/ryanpetrello/venvs/tmp-f30da7ecd0904ce6/facts/foo/bar'

ok: [foo/bar]

PLAY RECAP ******************************************************************************************************************************************************
foo/bar                    : ok=1    changed=0    unreachable=0    failed=0