search

ansible / ansible

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy and maintain. Automate everything from code deployment to network configuration to cloud management, in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com.
https://www.ansible.com/
GNU General Public License v3.0
62.7k stars 23.87k forks source link

Amazon cloud _facts modules need to be renamed to _info #57274

Closed felixfontein closed 5 years ago

felixfontein commented 5 years ago
SUMMARY

Modules should only be called _facts if they return ansible_facts, and ansible_facts should only be used for system-specific information. Information on cloud providers is not system specific. (See #54280 and this checklist.) Since this has only been clarified shortly before Ansible 2.8 went into feature freeze, it was decided to do bulk renames for Ansible 2.9.

Below you can find a list of modules from modules/cloud/amazon which are called _facts but seem to not return ansible_facts at all. These should be renamed (similarly to #56822).

ISSUE TYPE
COMPONENT NAME

aws_acm_facts aws_az_facts aws_caller_facts aws_kms_facts aws_region_facts aws_sgw_facts aws_waf_facts cloudwatchlogs_log_group_facts ec2_ami_facts ec2_asg_facts ec2_customer_gateway_facts ec2_eip_facts ec2_elb_facts ec2_eni_facts ec2_group_facts ec2_instance_facts ec2_lc_facts ec2_placement_group_facts ec2_snapshot_facts ec2_vol_facts ec2_vpc_dhcp_option_facts ec2_vpc_endpoint_facts ec2_vpc_igw_facts ec2_vpc_nacl_facts ec2_vpc_nat_gateway_facts ec2_vpc_net_facts ec2_vpc_peering_facts ec2_vpc_route_table_facts ec2_vpc_subnet_facts ec2_vpc_vgw_facts ec2_vpc_vpn_facts ecs_taskdefinition_facts elasticache_facts elb_application_lb_facts elb_classic_lb_facts elb_target_facts elb_target_group_facts iam_mfa_device_facts iam_role_facts iam_server_certificate_facts rds_instance_facts rds_snapshot_facts redshift_facts route53_facts

ANSIBLE VERSION

2.9.0

ansibot commented 5 years ago

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibot commented 5 years ago

cc @Etherdaemon @Java1Guy @Madhura-CSI @Sodki @gurumaia @iiibrad @j-carl @kaczynskid @linuxdynasty @michaeljs1990 @mikedlr @mjschultz @mmochan @nand0p @naslanidis @nerzhul @orthanc @prasadkatti @psykotox @pwnall @sdubrul @whiter @willricardo @willthames @wimnat @yaakov-github click here for bot help

ansibot commented 5 years ago

@felixfontein, just so you are aware we have a dedicated Working Group for aws. You can find other people interested in this in #ansible-aws on Freenode IRC For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

ansibot commented 5 years ago

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help