search

ansible / ansible_tower_client_ruby

Ruby gem for the Ansible Tower REST API
https://ansible.com/tower
MIT License
18 stars 41 forks source link

Set the faraday logger when creating connection #110

Closed agrare closed 6 years ago

agrare commented 6 years ago

Set the faraday response logger when creating a new Faraday object. Allow the logger to be set as an option to the AnsibleTowerClient::Connection or fall back to the AnsibleTowerClient.logger.

agrare commented 6 years ago

@miq-bot assign @Fryguy

miq-bot commented 6 years ago

Checked commit https://github.com/agrare/ansible_tower_client_ruby/commit/346b6a7a27b998e489951e37b0890c3058eb9cd4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 0 offenses detected Everything looks fine. :+1:

Fryguy commented 6 years ago

LGTM @syncrou ?

JPrause commented 6 years ago

@miq-bot add_label blocker

miq-bot commented 6 years ago

@JPrause Cannot apply the following label because they are not recognized: blocker

JPrause commented 6 years ago

@bdunne if this can be backported, can you add the gaprindashvili/yes label

bdunne commented 6 years ago

@JPrause those labels don't apply to this gem. The consumer would have to pull in the version that fixes their bug.