Update bundler, rake, remove unnecessary load path mangling

[djberg96]

This updates the gemspec by updating the bundler and rake versions, removes some unnecessary load path mangling, and gets rid of the require_paths specification since 'lib' is already the default.

Edit: also realized factory_girl needed to be updated to factory_bot.

[djberg96]

@Fryguy @bdunne Please review.

Edit: shoulda added @syncrou

[djberg96]

Note that I had to update the dynamic attribute syntax.

Also note that with factory_bot > 5 there's a failure on instance_id being an undefined method in the response factory, so I've pinned it to 4.11 for now.

[djberg96]

@miq-bot add_reviewer @syncrou

[miq-bot]

@djberg96 'syncrou' is an invalid reviewer, ignoring...

[Fryguy]

Just to extend on the comment threads here: https://github.com/ansible/ansible_tower_client_ruby/pull/128#discussion_r278329261 and here: https://github.com/ansible/ansible_tower_client_ruby/pull/128#discussion_r278323283

We didn't do this, bundler did, as it was used for gem creation, and most of the changes here undo the bundler default way (not saying we shouldn't merge, just clarifying). Try it locally with bundle gem foo_bar and you can see it still creates the $LOAD_PATH, require_paths, and add_development_dependency lines from the gemspec, and the before_install line in .travis.yml.

[djberg96]

I'm actually going to make one minor modification, which is to make the deps less pessimistic.

[miq-bot]

Checked commits https://github.com/djberg96/ansible_tower_client_ruby/compare/36d8e42180e438a2ecac47027a0d5b09c858f429~...2c270f01fc744ef982f9f8509aa7cff7e2e4aa9f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 3 files checked, 1 offense detected

**

• [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Yaml - missing config files

[gmcculloug]

@jrafanie Are you good with these last changes? Comment https://github.com/ansible/ansible_tower_client_ruby/pull/128/commits/2c270f01fc744ef982f9f8509aa7cff7e2e4aa9f

[jrafanie]

@gmcculloug yeah, those are dev dependencies. I'm good with making them less strict.