search

ansible / ansible_tower_client_ruby

Ruby gem for the Ansible Tower REST API
https://ansible.com/tower
MIT License
18 stars 41 forks source link

Fix specs with VCRs recorded on previous versions #141

Closed agrare closed 4 years ago

agrare commented 4 years ago

Previous versions of this gem requested /config/ to avoid redundant redirects (added in https://github.com/ansible/ansible_tower_client_ruby/pull/124). Now it is requesting /config which is causing vcr breakages after https://github.com/ansible/ansible_tower_client_ruby/pull/137 changed this

Failure on manageiq hammer on first run after v0.21.0 was released https://travis-ci.org/ManageIQ/manageiq/builds/651202354#L1149

miq-bot commented 4 years ago

Checked commit https://github.com/agrare/ansible_tower_client_ruby/commit/30fb728678f4a60467465f4be7c4365a7a090dd1 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie:

bdunne commented 4 years ago

FYI... The trailing / avoids unnecessary redirects. https://github.com/ansible/ansible_tower_client_ruby/pull/124

agrare commented 4 years ago

@bdunne yup

Previous versions of this gem requested /config/ to avoid redundant redirects (added in #124).

:smile: