ansible / ansibullbot

Bot for management of Ansible issues and PRs on GitHub.
GNU General Public License v3.0
203 stars 126 forks source link

Review backport PR diffs #1016

Open mattclay opened 6 years ago

mattclay commented 6 years ago

PRs for stable branches should be reviewed by the bot to determine if the diff is an exact match for the original PR in devel. If there is a match, apply a label, perhaps something like exact_backport to the PR. If commits are added/changed, the bot should re-evaluate the PR and remove the label if it no longer applies.

The comparison should ignore a missing changelog fragment in the devel diff. This will handle the situation where the changelog fragment was only added in the backport PR.

This will reduce the burden on release managers reviewing backport PRs, as most PRs cherry pick cleanly, making the comparison easy for the bot (assuming -x was used to identify the original).

abadger commented 5 years ago

Other things to check on backports: