ansible / ansibullbot

Bot for management of Ansible issues and PRs on GitHub.

GNU General Public License v3.0

203 stars 126 forks source link

assertEquals is deprecated #1549

Closed mkrizek closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #1549 (67bd74f) into master (5e845fb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1549   +/-   ##
=======================================
  Coverage   60.49%   60.49%           
=======================================
  Files          56       56           
  Lines        8411     8411           
=======================================
  Hits         5088     5088           
  Misses       3323     3323

webknjaz commented 3 years ago

FWIW I'd recommend switching over to assert x == y syntax as it's what works best with pytest.

mkrizek commented 3 years ago

Yeah, that is the end goal, to migrate away from unittest (and increase code coverage, make unit tests faster, ...).

webknjaz commented 3 years ago

Yep, OTOH this specific change doesn't require removing import unittest and can be done right away.