Closed rooftopcellist closed 1 year ago
@rooftopcellist - I may take a crack at this. But since I have never done this before I did a have question regarding the variables. For example job_template_inventory, is the expectation for it to be just inventory?
Based on job template, looking at the API I see
{
"name": "",
"description": "",
"job_type": "run",
"inventory": null,
"project": null,
"playbook": "",
"scm_branch": "",
"forks": 0,
"limit": "",
"verbosity": 0,
"extra_vars": "",
"job_tags": "",
"force_handlers": false,
"skip_tags": "",
"start_at_task": "",
"timeout": 0,
"use_fact_cache": false,
"execution_environment": null,
"host_config_key": "",
"ask_scm_branch_on_launch": false,
"ask_diff_mode_on_launch": false,
"ask_variables_on_launch": false,
"ask_limit_on_launch": false,
"ask_tags_on_launch": false,
"ask_skip_tags_on_launch": false,
"ask_job_type_on_launch": false,
"ask_verbosity_on_launch": false,
"ask_inventory_on_launch": false,
"ask_credential_on_launch": false,
"ask_execution_environment_on_launch": false,
"ask_labels_on_launch": false,
"ask_forks_on_launch": false,
"ask_job_slice_count_on_launch": false,
"ask_timeout_on_launch": false,
"ask_instance_groups_on_launch": false,
"survey_enabled": false,
"become_enabled": false,
"diff_mode": false,
"allow_simultaneous": false,
"job_slice_count": 1,
"webhook_service": null,
"webhook_credential": null,
"prevent_instance_group_fallback": false
}
should variable names match exactly as seen here? Or should they have a prefix like job_template_X, where X is the variable name from that list?
The parameters on the JobTemplate spec are named in a way that is not consistent with the AWX API. For example:
I think we should deprecate these parameters and introduce and document new ones that align with the naming used in the AWX API.
The above are just the ones in the CRD, however, there are a lot of "passthrough" JobTemplate parameters which we may want to deprecate and shim for a release in case anyone is relying on them.