Modifying Job Template parameters to be consistent with AWX API

rlopez133 commented 1 year ago

The goal of this PR is to have the Job Template parameters be consistent with the AWX API. Fixes: #111

It does the following based on the Checklist from #111 :

Checklist

[x] Deprecate the existing params we wish to change (done in the CRD)
[x] Create new entries for the new name
[x] Update the clusterServiceVersion UI form spec.descriptors so that the deprecated ones are hidden
[x] Also in the CSV base template, add spec.descriptor entries for the new params
[x] Add logic in the job_template role to check for the old param name and use it if the preferred (new) on is not set. This can be done here I think.

Things to note:

I did not include a README in this PR as placed in the checklist of #111
custom_virtualenv: "{{ job_template_venv | default(omit) }}" , I didn't see it in the AAP API, so I left it alone.

@rooftopcellist - please verify thoroughly as I've never done this before :)

cooktheryan commented 1 year ago

this is failing due to a broken test. When the tests from the iaac-poc branch are brought over then the tests will pass. I could also carry over the tests to the devel branch in a separate PR if that is wanted /cc @rooftopcellist

rooftopcellist commented 1 year ago

I tested this out with the old params and the new params, and all is working as expected. Thanks for the contribution @rlopez133 !

ansible / awx-resource-operator

Modifying Job Template parameters to be consistent with AWX API #116

Checklist