ansible / awx-resource-operator

41 stars 31 forks source link

Add Variables to inventory #139

Closed neevnuv closed 6 months ago

neevnuv commented 8 months ago

137

Added variables to ansible inventory CR, Made a few tweaks:

Aligned the description of the inventory properties with the parameters of the awx.awx.inventory module we use.
Made instance_group a list
Added for state property an enum aligned with the awx.awx.inventory module
Added first commits for adding kind. Comments a few lines to not create error related to it
Added connection secret to descriptors
Added variables to sample inventories as example

neevnuv commented 8 months ago

CI Pipeline Fixes:

CI/pull request: failed due to linting error, I fixed it in this commit.
- AWX Integration / minikube-test: failed due to timeout for ansiblejob success. The logs show the job was created successsfully. plus I didn't make changes to the jobs, so it is weird my commits affected this task.

rooftopcellist commented 6 months ago

@neevnuv Thank you for your contribution! All of the changes here look good and work as expected. Thank you for taking care to add to the samples in addition to your changes to increase coverage.

I know I mentioned on another comment that we should add the x-descriptor for the connection_secret, but that can be handled in another PR and shouldn't hold this change up.

It looks like a re-run of the CI passed (I increased the timeout since your initial run - here)