Update InstanceGroup and Add Build Runner in MAKEFILE

neevnuv commented 6 months ago

This PR is a bundle of small changes that fixes the usage of InstanceGroup CR and separates instancegroups and container groups in the UI and description.

Changes:

Rename policy_spec_override to pod_spec_override to allign with the awx collection. Plus, after looking into the code of the runner, the environment variable of POLICY_SPEC_OVERRIDE was never used.
Added variables for max_concurrent_jobs and max_forks in CSV and CRD of instanceGroup.
Remove the credential from required. This is due to the credential only being needed for credentialGroups and not for instanceGroups.
Adjusted the CSV to show InstanceGroup variables when is_credential_group is false and show ContainerGroup variables when is_credential_group is true
Added in make file a small part to allow building the runner image. In the future should add an option to specify the runner image in the deploy. Plus added a line about this in the documentation.
Moved the instance group samlpes in a directory for instancegroups. Then added a CR that deploys a ContainerGroup and another that deploy an InstanceGroup.
Added ifs to the job definition template of the instance group to not require all the variables to be specified.

This was opened to solve #161

neevnuv commented 6 months ago

Thanks for running the pipelines. I see changing the samples file location failed the pipeline, I'll fix it.

neevnuv commented 5 months ago

hi @rooftopcellist, I think the PR is ready. I would love it if you would go over it and merge it 😁

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ansible / awx-resource-operator

Update InstanceGroup and Add Build Runner in MAKEFILE #162

Quality Gate passed