search

ansible / awx-resource-operator

41 stars 34 forks source link

Added role and supporting files to create AnsibleExecutionEnvironment #163

Open AaronJaegerVA opened 1 month ago

AaronJaegerVA commented 1 month ago

Will someone please tell me if I am on the right track here? I did my best to reverse engineer what is in place for other resources already. I am attempting to enable creation of Execution Environments via CRs fed to the awx-resource operator.

AaronJaegerVA commented 1 month ago

Fixes #135

neevnuv commented 1 month ago

Hello Aaron, this PR looks great! Is it possible to add to the CRD the credential variable (as seen in the documentation for awx.awx)? And it seems you also need to add the connection_secret variable to the CRD.

Plus, you are missing the CR reference in the CSV resource, you can use the other resources in the yaml as a guide. Lastly, I noticed this status needs renaming to execution environment instead of Job Template.

You did an amazing job, good work!

AaronJaegerVA commented 1 month ago

@neevnuv, Thanks for the review. I'll get these issues addressed and push another commit.

AaronJaegerVA commented 1 month ago

@neevnuv Your "this status" link is broken. Which file are you referring to when you mentioned the "status" needing to be renamed?

Nevermind, I found it.

AaronJaegerVA commented 1 month ago

@neevnuv I'm ready for another review :)

AaronJaegerVA commented 1 month ago

@neevnuv, I have made the changes you recommended. Please have another look at your earliest convenience.

AaronJaegerVA commented 2 weeks ago

@neevnuv Whenever you get a few minutes, please let me know if there are any other changes that need to be made. Thanks! 😄