search

ansible / awx-resource-operator

41 stars 34 forks source link

fix job template crd #33

Closed mikeshng closed 4 years ago

mikeshng commented 4 years ago

Signed-off-by: Mike Ng ming@redhat.com

The current job template crd will always fail with the error ... is invalid: tower_auth_secret: Required value

xiangjingli commented 4 years ago

@mikeshng Sorry I didn't see this PR before I merged the my CRD fix. That caused the conflicts. Could you provide a new PR after merging my CRD fix, when you have cycle next week.

mikeshng commented 4 years ago

Hi @xiangjingli I just merged with latest changes. I also tested it with the example CR we have https://github.com/ansible/awx-resource-operator/blob/devel/deploy/crds/tower.ansible.com_v1alpha1_jobtemplate_cr.yaml and it seems fine.

xiangjingli commented 4 years ago

@mikeshng Please also update the jobtemplate crd yam here

deploy/olm-catalog/awx-resource-operator/manifests/tower.ansible.com_jobtemplates_crd.yaml. This is the actual CRD file in operator bundle image.

mikeshng commented 4 years ago

@xiangjingli nice catch Xiangjing. I've updated the operator bundle CRD.

mikeshng commented 4 years ago

release-0.1 branch has been cherry picked with this change.