search

ansible / awx

AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.
Other
14.01k stars 3.42k forks source link

Improve Slack Notification Error Handling #1048

Open wwitzel3 opened 6 years ago

wwitzel3 commented 6 years ago
ISSUE TYPE
COMPONENT NAME
SUMMARY

Currently we only surface errors when sending slack notification if a Python exception occurs. We could do better if we read the event stream after our rtm_send_message call to see if there were any error events waiting.

A common error is when the bot has not been invited to a channel that we are attempting to send the notification to. This can be caught in the message stream, but does not throw an exception.

ADDITIONAL INFORMATION

https://github.com/ansible/awx/blob/devel/awx/main/notifications/slack_backend.py#L49

tanujdevops commented 2 years ago

Hi @wwitzel3, I would like to take up this issue. Can you please assign it to me?

matburt commented 2 years ago

No one is actively working on it. Just do the work and submit a PR