search

ansible / awx

AWX provides a web-based user interface, REST API, and task engine built on top of Ansible. It is one of the upstream projects for Red Hat Ansible Automation Platform.
Other
13.5k stars 3.34k forks source link

Support Django logout redirects #15148

Closed manstis closed 5 days ago

manstis commented 3 weeks ago
SUMMARY

This PR allows specification of Django's auth_views.LogoutView.success_url_allowed_hosts from settings.

ISSUE TYPE
COMPONENT NAME
AWX VERSION
awx: 24.3.1.dev9+g4d163c3330
ADDITIONAL INFORMATION

This has been discussed on #aap-controller on Slack.

I managed to step through the code with sdb to check the settings change has no ill affect.

This PR will need an accompanying PR for awx-controller to be able to set the new environment variable from then operator.

This part of the code-base seems sparse of unit tests.. IDK if you require some?

manstis commented 3 weeks ago

I probably don't even need to change awx-operator as we can set the new environment variable as an extra_setting unless you want to make the new environment variable more public (e.g. include in the CRD/CSV as an explicit parameter)..